-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add picture-lqip format with low quality base64 image #662
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: dfc32a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 33 33
Lines 1235 1270 +35
Branches 206 212 +6
=======================================
+ Hits 1163 1196 +33
- Misses 72 74 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
93bed57
to
5d9d1e2
Compare
If I understood the code here correctly, it looks like this isn't really transforming the image in a way that makes it much smaller (e.g. to display just the dominant background color). I think if we were going to add a feature like this we should do it with different transforms that shrink the image in various ways as mentioned in #86 (comment). We don't have to add them all off the bat, but it might be nice to have two options people could choose between to help us figure out the API |
It actually takes the smallest size that you specify in the transform for the low quality preview. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the new behavior (if this is a feature change)?
The picture output can have a low quality base64 image.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
PR?)
No
Other information: